Added support for the Philips Hue Smart Plug #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiera-robinson-st
requested review from
cjswedes,
dljsjr,
elbe0046,
FreeMasen,
greens,
kianooshkarami,
lelandblue,
NoahCornell,
tandres,
tpmanley and
varzac
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 56f4a0a |
|
For some reason, OneApp isn't showing any devices that I onboard today. But the device does onboard to the driver just fine, and I've tested control via the CLI. Here's a screenshot:
|
|
Working from OneApp now:
|
dljsjr
approved these changes
May 1, 2024
tpmanley
reviewed
May 1, 2024
|
Channel deleted. |
tpmanley
reviewed
May 1, 2024
| @@ -0,0 +1,12 @@ | |||
| name: SmartPlug | |||
There was a problem hiding this comment.
It's not required, but I think we typically try to make the name match the filename
greens
reviewed
May 1, 2024
dljsjr
changed the base branch from
feat/new-device-types
to
feat/device/motion-and-contact-sensors
dljsjr
force-pushed
the
feat/device/motion-and-contact-sensors
branch
from
1b281d9 to
62f4ab1
Compare
dljsjr
force-pushed
the
feat/device/smartplug
branch
from
5480c3e to
f969440
Compare
dljsjr
force-pushed
the
feat/device/motion-and-contact-sensors
branch
from
62f4ab1 to
053faea
Compare
dljsjr
force-pushed
the
feat/device/smartplug
branch
2 times, most recently
from
3cc39f1 to
df57efc
Compare
dljsjr
force-pushed
the
feat/device/motion-and-contact-sensors
branch
from
053faea to
201601d
Compare
dljsjr
force-pushed
the
feat/device/smartplug
branch
from
df57efc to
007b231
Compare
dljsjr
force-pushed
the
feat/device/motion-and-contact-sensors
branch
from
201601d to
38c597c
Compare
dljsjr
force-pushed
the
feat/device/smartplug
branch
3 times, most recently
from
87f4c8a to
488b34b
Compare
Did this last week and forgot to ping you. |
tpmanley
approved these changes
May 6, 2024
cjswedes
approved these changes
May 6, 2024
NoahCornell
approved these changes
May 6, 2024
greens
approved these changes
May 6, 2024
Philips Hue Smart Plug is exposed as a 'light' service so existing light code was modified to include the case for Philips Hue Smart Plug new device adoption and use
This is the Hue Dimmer Remote and the Hue Tap Dial. Note that we do *not* yet have support for the rotary portion of the tap dial.
Philips Hue Smart Button is exposed as a 'button' service in addition to including the 'device_power' service. Development and inclusion of this device driver was modelled after the 4-button-remote device driver
This refactor furthers the generalizations done previously for devices that provide multiple services to allow for not only mapping of services to capabilities or components, but also multiple device records. This allows for us to support devices such as the Dymera up/down light. Other changes: - I found myself frequently introducing bugs related to using the Hue Bridge ID (MAC Address) as a Device ID, and the Bridge Device ID as a Hue Bridge ID. We renamed all instances of `bridge_id` referencing the MAC to `bridge_network_id` to try and alleviate the confusion. - Button support is further generalized to support two-button models, which covers the In-Wall Switch Module in the 2-gang configuration.
- Fixes an issue where compound devices wouldn't be labeled properly - Fixes an issue where the stray device task was scanning a bridge every time it onboarded, even if there were no strays - Fixes an issue where refresh on devices could fail early in driver start by accidentally passing in an API Key string instead of an API Rest Client instance to a function - Fixes an issue where multi-service devices (Buttons, Motion Sensors, Contact Sensors) could sometimes fail to emit attributes if their init handler ran before their parent bridge's network connection was open. Move `battery` above refresh in profile for motion Remove debug logic from tamper emit Remove unused Rooms API calls Replace strings with consts in API methods Add missing early return in button attribute handler Early return in device discovery for unsupported buttons Move debug logs to correct function Update category for single button profile Fix duped line from bad rerere rebase Finish SSE event stream generalizations Tidy up docs/logs that still assume lights-only Generalize stray device handling Normalize module structures
dljsjr
force-pushed
the
feat/device/smartplug
branch
from
5a47c05 to
56f4a0a
Compare
dljsjr
merged commit 0e05ca8
into
feat/device/motion-and-contact-sensors
8 checks passed
|
Invitation URL: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Philips Hue Smart Plug is exposed as a 'light' service so existing light code was modified to include the case for Philips Hue Smart Plug new device adoption and use