Rolling the Beta changes to Production #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHAD-12999] fix (Zigbee Lock): Ignore unknown status for sds lock
Test Coverage Review Modified
Signed-off-by: Ma Xinjian <[email protected]>
Add TC to improve motion sensor code test coverage
fix Aqara Wireless Button E1 reonboarding issue
Subscribe to min/max color temperature and min/max switch level attributes rather than reading them during device init.
…t-reads-subscription Matter-Switch: Limit reads subscriptions
Only set the find_child function for parent-child devices. This is because in cases where a bridge is onboarded with many devices, the set_find_child function is call which sets the find_child function. When the bridge is onboarded, it then calls get_devices() when when the first event is emitted because the device checks for any child devices the current device might have. This get_devices() call ends up adding all devices in the driver to the device cache. Once in the device cache, the `init` event is skipped. However, there is a race condition where when adding a large number of bridged devices, some devices can be added to the device cache before they have initialized, causing them to miss the `init` event. This happens when a device with a find_child function emits an event for a specific endpoint, because when it emits and event for an endpoint, it calls the find_child function to see if there is a child device that it should emit the event for, which causes the get_devices() functions to be called as described above, adding some as yet uninitialized devices to the device cache incorrectly.
Matter Switch: only set_find_child for parent-child devices
Rolling Main to Beta
|
Channel deleted. |
Test Results 57 files 364 suites 0s ⏱️ Results for commit e629932. |
|
matter-switch_coverage.xml
zigbee-button_coverage.xml
zigbee-lock_coverage.xml
zigbee-motion-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against e629932 |
greens
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the Edge Driver weekly deploy rolling Beta to Production