Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible re-onboarding issue #1366

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix possible re-onboarding issue #1366

merged 1 commit into from
May 13, 2024

Conversation

Kwang-Hui
Copy link
Contributor

Fix possible reboarding issue

  • move device settings to doConfigure

@CLAassistant
Copy link

CLAassistant commented May 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/NxlwY5gp3vMA

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Test Results

   57 files    364 suites   0s ⏱️
1 761 tests 1 761 ✅ 0 💤 0 ❌
3 056 runs  3 056 ✅ 0 💤 0 ❌

Results for commit 71ad3b1.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

File Coverage
All files 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-illuminance-sensor/src/aqara/init.lua 92% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 71ad3b1

@lelandblue lelandblue requested review from greens, cbaumler and wkhenon May 7, 2024 21:15
@lelandblue
Copy link
Contributor

The ticket this work is referencing is STSE-2615

@lelandblue
Copy link
Contributor

Hey @Kwang-Hui it is not clear if this is a known issue or not. Can you please clarify if this issue is occurring?

@Kwang-Hui
Copy link
Contributor Author

Kwang-Hui commented May 8, 2024 •
edited
Loading

Hey @Kwang-Hui it is not clear if this is a known issue or not. Can you please clarify if this issue is occurring?

Let me update on STSE-2615

@lelandblue lelandblue merged commit be2f7d9 into SmartThingsCommunity:main May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greens greens greens approved these changes

@cbaumler cbaumler Awaiting requested review from cbaumler

@wkhenon wkhenon Awaiting requested review from wkhenon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kwang-Hui @CLAassistant @lelandblue @greens