Rolling up beta to production #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convert_to_signedInt16 function had a bug preventing it from handling large negative threeAxis values. This would impact the garage door handling since in the typical orientation the sensor will report approximately -1000 for the Z axis when the door is open. https://smartthings.atlassian.net/browse/CHAD-13097
SmartSense Multi: Fix handling of large negative threeAxis values
The original SmartSense Multi has a different z-axis than the newer sensors. When installed on the garage door it is parallel to the ground when the door is closed and perpendicular to the ground when the door is open. For this reason it can't share the garage door handling code that the newer sensors use. This change implements the necessary custom handling and adds a unit test. https://smartthings.atlassian.net/browse/CHAD-13098
zigbee-contact: Fix garage door handling for SmartSense Multi
Weekly deploy from Main to Beta
|
Invitation URL: |
Test Results 57 files 364 suites 0s ⏱️ Results for commit f1c40c2. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f1c40c2 |
greens
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.