Add Matter 1.2 clusters directly to drivers #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 59 files 370 suites 0s ⏱️ For more details on these failures and errors, see this check. Results for commit f14c55a. ♻️ This comment has been updated with latest results. |
|
matter-appliance_coverage.xml
matter-rvc_coverage.xml
matter-sensor_coverage.xml
matter-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against f14c55a |
ctowns
changed the base branch from
matter-v1.2-drivers
to
matter-v1.2-drivers-combined
ctowns
requested review from
tpmanley,
samadDotDev,
gharveymn,
Con-Tejus,
z-michel,
hcarter-775 and
nickolas-deboom
|
This still needs some clean up, but with these changes in place I am able to successfully test with the Matter 1.2 drivers on a hub with 52 lua libs (i.e. without the Matter 1.2 cluster definitions). I will plan to do some more clean up, but this should be pretty close. With these changes in place, we shouldn't need to depend on a lua libs update to support Matter 1.2 device types on all hubs. Overall, the driver memory footprint has some modest savings in most cases when using the built-in cluster definitions in the driver. However, there are large savings for Air Quality Sensor due to compressing the 12 optional concentration measurement clusters down and having them utilize one base ConcentrationMeasurement cluster definition. All other drivers had smaller memory decreases, but still noticeable. In all cases, the drivers are not near the driver disk space limit (different from memory limit) thanks to comment stripping and cutting out unnecessary bloat from the cluster definitions. There is probably opportunity for more trimming as well. Here are some memory stats for each of the 4 drivers with a specific device type: Matter Thermostat - Room AC Matter RVC - Robot Vacuum Cleaner Matter Appliance - Dishwasher |
ctowns
commented
May 30, 2024
drivers/SmartThings/matter-appliance/profiles/refrigerator-freezer-tn-tl.yml
Show resolved
Hide resolved
|
Ticket Reference for this is : CHAD-13240 |
|
Added a link to a confluence page summarizing the testing for this change here: https://smartthings.atlassian.net/wiki/spaces/~62de3b63b6b0b70770d7905d/pages/3238854850/Matter+1.2+VDA+Testing+with+Driver+Clusters This is also linked in the top comment on this PR. |
ctowns
force-pushed
the
include-matter-1-2-clusters
branch
from
3bb5214 to
bd0a847
Compare
tpmanley
reviewed
Jun 4, 2024
tpmanley
reviewed
Jun 4, 2024
drivers/SmartThings/matter-appliance/src/matter-refrigerator/init.lua
Outdated
Show resolved
Hide resolved
tpmanley
reviewed
Jun 4, 2024
drivers/SmartThings/matter-appliance/src/matter-refrigerator/init.lua
Outdated
Show resolved
Hide resolved
tpmanley
reviewed
Jun 4, 2024
tpmanley
reviewed
Jun 4, 2024
tpmanley
reviewed
Jun 4, 2024
ctowns
force-pushed
the
include-matter-1-2-clusters
branch
from
3606f6c to
8077b21
Compare
|
I added the embedded clusters for matter-pump since they were missing in my first pass of this. Also, I added additional handing for the get_endpoints function for cases when we are running older lua libs and must rely on the embedded clusters for things like feature maps. I added the |
HunsupJung
approved these changes
Jun 5, 2024
tpmanley
reviewed
Jun 5, 2024
tpmanley
reviewed
Jun 5, 2024
tpmanley
approved these changes
Jun 5, 2024
ctowns
force-pushed
the
include-matter-1-2-clusters
branch
from
8077b21 to
3e99f2d
Compare
Adds stripped down versions of clusters directly to drivers so that we do not need to depend on lua libs releases. Also adds some test files for drivers where they were missing.
ctowns
force-pushed
the
include-matter-1-2-clusters
branch
from
3e99f2d to
92da754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds stripped down versions of clusters directly to drivers so that we do not need to depend on lua libs releases.
Also adds some test files for drivers where they were missing.
Each device type was tested with a hub running 52 lua libs (without Matter 1.2 clusters) while running these drivers. Each attribute was then tested by checking each value for the attribute and confirming that the hub can properly receive updates to that value and also set that value correctly where applicable. This testing is summarized here: https://smartthings.atlassian.net/wiki/spaces/~62de3b63b6b0b70770d7905d/pages/3238854850/Matter+1.2+VDA+Testing+with+Driver+Clusters