Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fingerprints of TOTEM Door Lock for SmartThingsEdgeDriver #1431

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Add fingerprints of TOTEM Door Lock for SmartThingsEdgeDriver #1431

merged 3 commits into from
Jun 17, 2024

Conversation

FrankSpringfield
Copy link
Contributor

The fingerprints of TOTEM Door Lock have already existed in the DTH(SmartThings Public).
I tried to manage to migrate the fingerprints from DTH to Edge Driver.

Zigbee Device ID: "TOTEM H60/H90" & "TOTEM P30"

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lelandblue
Copy link
Contributor

Hello, at this time we are only accepting new fingerprint submissions as part of the WWST Works With SmartThings Program. If you work for a device company and would like your device WWST Certified please reach out to [email protected] or check out more information here.

@FrankSpringfield
Copy link
Contributor Author

Hello, I'm now an intern working at SRC-N. The TOTEM fingerprints already exist in the DTH(SmartThings Public). My leader wants me to migrate the fingerprints from DTH to Edge Driver.

@lelandblue
Copy link
Contributor

Hey @FrankSpringfield Can you provide the JIRA ticket that your working from so we can have more discussion internally?

@FrankSpringfield
Copy link
Contributor Author

FrankSpringfield commented Jun 11, 2024 •
edited
Loading

Hi, the JIRA ticket is here:
https://smartthings.atlassian.net/browse/WWST-8009.
https://smartthings.atlassian.net/browse/WWST-8010.

wkhenon
wkhenon approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@wkhenon wkhenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@lelandblue lelandblue requested review from greens and cbaumler June 12, 2024 11:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

Test Results

   59 files    374 suites   0s ⏱️
1 807 tests 1 807 ✅ 0 💤 0 ❌
3 129 runs  3 129 ✅ 0 💤 0 ❌

Results for commit 65c3d9e.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

Test Results

   59 files    375 suites   0s ⏱️
1 807 tests 1 795 ✅ 0 💤 0 ❌ 12 🔥
3 129 runs  3 117 ✅ 0 💤 0 ❌ 12 🔥

For more details on these errors, see this check.

Results for commit d3f5b05.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

File Coverage
All files 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/yale/init.lua 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua 98% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d3f5b05

@FrankSpringfield
Copy link
Contributor Author

Hi, @lelandblue.
Considering that the 'base-lock' profile has one additional capability, 'lockCodes', compared to the 'lock-battery' profile, in this commit I have changed the deviceProfileName from 'lock-battery' to 'base-lock'.
After testing, we confirmed that the TOTEM H60 can be onboarded correctly through SmartThings after updating the edge driver.

@lelandblue lelandblue merged commit 88e9b09 into SmartThingsCommunity:main Jun 17, 2024
9 of 11 checks passed
dljsjr pushed a commit that referenced this pull request Jun 24, 2024
@FrankSpringfield @lelandblue @dljsjr
Add fingerprints of TOTEM Door Lock for SmartThingsEdgeDriver (#1431)
8e31aa9 
* migrate fingerprints of TOTEM Door Lock from DTH to Edge Driver

* Change the profile to 'base-lock'

---------

Co-authored-by: lelandblue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greens greens greens approved these changes

@wkhenon wkhenon wkhenon approved these changes

@lelandblue lelandblue lelandblue approved these changes

@cbaumler cbaumler Awaiting requested review from cbaumler

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FrankSpringfield @CLAassistant @lelandblue @greens @wkhenon