Matter Switch: ensure device init is called on added #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 59 files 375 suites 0s ⏱️ For more details on these errors, see this check. Results for commit ed8fe8f. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ed8fe8f |
samadDotDev
approved these changes
Jun 14, 2024
Comment on lines
+517
to
+518
| -- call device init in case init is not called after added due to device caching | ||
| device_init(driver, device) |
There was a problem hiding this comment.
Just calling out here as well that this has been audited to be idempotent
Con-Tejus
approved these changes
Jun 14, 2024
ctowns
force-pushed
the
bugfix/matter-switch-init
branch
from
c49e121 to
ed8fe8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.