Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter Lock: remove Aqara unit tests for now #1449

Closed
wants to merge 1 commit into from

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Jun 17, 2024

Remove unit tests for Aqara door lock since they are using a new capability. We can add these back in once we have updated the CI.

Remove unit tests for Aqara door lock since they are using
a new capability. We can add these back in once we have
updated the CI.
Copy link

Test Results

   59 files    374 suites   0s ⏱️
1 807 tests 1 795 ✅ 0 💤 0 ❌ 12 🔥
3 129 runs  3 117 ✅ 0 💤 0 ❌ 12 🔥

For more details on these errors, see this check.

Results for commit baa9781.

Copy link

File Coverage
All files 74%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 71%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against baa9781

Copy link
Contributor

@hcarter-775 hcarter-775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, glad this is removed for now 👍

@ctowns ctowns closed this Jun 21, 2024
@ctowns
Copy link
Contributor Author

ctowns commented Jun 21, 2024

Will add these back with the 53 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants