-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zigbee-button for Vimar xx591 (Wall-mounted Remote Control) #1508
base: main
Are you sure you want to change the base?
Add zigbee-button for Vimar xx591 (Wall-mounted Remote Control) #1508
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Invitation URL: |
Test Results 64 files + 4 403 suites +26 0s ⏱️ ±0s Results for commit 7fbfc0c. ± Comparison against base commit c936387. This pull request removes 4 and adds 191 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7fbfc0c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the FirmwareUpdate capability is handled completely by us and we'd prefer to have it for all of our zigbee devices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Steven, thanks for your note. This product handles OTA firmware updates via Bluetooth, through the official app for installers. Other Vimar products certified in SmartThings have a similar profile for the same reason. I'll stick with this, if possible.
@@ -0,0 +1,215 @@ | |||
-- Copyright 2022 SmartThings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Add support for: