Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zigbee-button for Vimar xx591 (Wall-mounted Remote Control) #1508

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sciaccom-vimar
Copy link
Contributor

Add support for:

  • Vimar Remote Control (xx591, IoT Connected Device Mechanism)

Copy link

github-actions bot commented Jul 9, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Jul 9, 2024

Copy link

github-actions bot commented Jul 9, 2024

Test Results

   64 files  +  4    403 suites  +26   0s ⏱️ ±0s
2 008 tests +187  2 008 ✅ +187  0 💤 ±0  0 ❌ ±0 
3 462 runs  +303  3 462 ✅ +303  0 💤 ±0  0 ❌ ±0 

Results for commit 7fbfc0c. ± Comparison against base commit c936387.

This pull request removes 4 and adds 191 tests. Note that renamed tests count towards both.
Handle received Lock State from Matter device.
Min and max cooling setpoint attributes do not set capability constraint for RPC version less than 4
Min and max temperature attributes do not set capability constraint for RPC version less than 4
Min and max temperature attributes do not set capability constraint when RPC version is less than 4
Active power measurement should generate correct messages
Add Credential command received from SmartThings and commandResult is busy
Add Credential command received from SmartThings and commandResult is invalidCommand
Add Credential command received from SmartThings and commandResult is resourceExhausted
Add Credential command received from SmartThings and user_index is occupied
Add User command received from SmartThings and commandResult is busy
Add Week Day Schedule command received from SmartThings and send busy state
Assert component to endpoint map
Assert profile applied over doConfigure
Battery voltage report should be handled, 48
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 9, 2024

File Coverage
All files 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/TRADFRI_remote_control.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/button_utils.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/somfy/somfy_situo_4.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/wallhero/init.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/SLED/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/supported_values.lua 99%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/heiman/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/frient/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/adurosmart/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/robb/init.lua 99%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ecosmart/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/iris/init.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/shinasystems/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/vimar/init.lua 96%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7fbfc0c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the FirmwareUpdate capability is handled completely by us and we'd prefer to have it for all of our zigbee devices

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Steven, thanks for your note. This product handles OTA firmware updates via Bluetooth, through the official app for installers. Other Vimar products certified in SmartThings have a similar profile for the same reason. I'll stick with this, if possible.

@@ -0,0 +1,215 @@
-- Copyright 2022 SmartThings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants