New Device (Matter Thermostat) Eve Thermostat #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lelandblue
requested review from
hcarter-775,
ctowns,
nickolas-deboom and
z-michel
Test Results 60 files 377 suites 0s ⏱️ Results for commit 16816fb. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 16816fb |
ctowns
approved these changes
Jul 15, 2024
| deviceLabel: Eve Thermo | ||
| vendorId: 0x130A | ||
| productId: 0x004F | ||
| deviceProfileName: thermostat-heating-only-nostate |
There was a problem hiding this comment.
Just a note that the matter-thermostat driver has dynamic profile naming, so when testing this we'll just want to confirm that the driver attempts to switch to this same profile when the device is onboarded. Should be easy to check by confirming that expected profile is still being used after the device is onboarded.
|
Channel deleted. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new Matter WWST request for a Eve Thermostat. The product ID for this device is "79 (0x4f)" and has a matter device type id of "769 (0x301)".