Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter Water Sensor Device Integration #1533

Merged
merged 17 commits into from
Aug 9, 2024

Conversation

hcarter-775
Copy link
Contributor

@hcarter-775 hcarter-775 commented Jul 18, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR includes protoype support for:

  • Water Leak Detector
  • Water Freeze Detector
  • Rain Sensor

Summary of Completed Tests

N/A

@hcarter-775 hcarter-775 changed the base branch from main to matter-v1.3-drivers July 18, 2024 18:03
Copy link

github-actions bot commented Jul 18, 2024

Channel deleted.

Copy link

github-actions bot commented Jul 18, 2024

Test Results

   61 files  ±0    379 suites  +2   0s ⏱️ ±0s
1 817 tests +2  1 753 ✅  - 22  0 💤 ±0  0 ❌ ±0  64 🔥 +24 
3 167 runs  +3  3 072 ✅  - 31  0 💤 ±0  0 ❌ ±0  95 🔥 +34 

For more details on these errors, see this check.

Results for commit 9be8e5d. ± Comparison against base commit 74630ed.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
Test profile change on init for Room AC device type
Boolean state freeze detection reports should generate correct messages
Boolean state leak detection reports should generate correct messages
Test profile change on init for Freeze and Leak combined device type

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 18, 2024

File Coverage
All files 40%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 10%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/server/attributes/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/server/attributes/SensorFault.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/types/SensorFaultBitmap.lua 76%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/types/Feature.lua 55%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/types/init.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/BooleanStateConfiguration/init.lua 75%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 9be8e5d

Copy link
Contributor

@ctowns ctowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need some profiles for this device type too!

Copy link

github-actions bot commented Aug 9, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

@hcarter-775 hcarter-775 merged commit 0148dd6 into matter-v1.3-drivers Aug 9, 2024
9 of 12 checks passed
@hcarter-775 hcarter-775 deleted the matter-sensor-water branch August 9, 2024 20:53
@hcarter-775 hcarter-775 restored the matter-sensor-water branch August 10, 2024 18:46
@hcarter-775 hcarter-775 deleted the matter-sensor-water branch August 10, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants