Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick WWST Matter Switch fingerprints in to Beta ahead of production #1534

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Cherry-pick WWST Matter Switch fingerprints in to Beta ahead of production #1534

merged 8 commits into from
Jul 22, 2024

Conversation

dljsjr
Copy link
Contributor

@dljsjr dljsjr commented Jul 22, 2024 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor
  • Release
    • This is a hotfix release or is otherwise outside of the normal driver release cadence

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This cherry-pick's the following PR's in to Beta ahead of the production release so that they will be hotfixed to production:

Summary of Completed Tests

N/A

lelandblue and others added 8 commits July 22, 2024 13:54
@lelandblue @dljsjr
new-device-AiDot-Orein- OS0100411267
7b941ac
@lelandblue @dljsjr
Adding additional Fingerprint for Linkind device
6bdc31a
@lelandblue @dljsjr
Adding additional fingerprint for the Oriein OS01006110
eda38f9
@ctowns @dljsjr
Matter Switch: new fingerprint for Cync Full Color A19
17db8e1
@lelandblue @dljsjr
new-devices-for-Cync-and-Winees
2d76ad5
@lelandblue @dljsjr
Adding additional Fingerprint for
74020e0 
Additional PR to add another recently opened WWST CERT request for a Cync Full Color A19, ModelNumber: CLEDA199CD1MS.  

vendorId: 0x1339
productId: 0x0015

I could not confirm the Matter Device Type ID
@lelandblue @dljsjr
Fix a bad commit
3b9d10d 
Removed a dupe fingerprint and added the following fingerprint. 

- id: 4921/107
  deviceLabel: Cync Reveal Full Color A19
  vendorId: 0x1339
  productId: 0x006B
  deviceProfileName: light-color-level-2000K-7000K
@lelandblue @dljsjr
Adding missed quotes around product ID
545862c
@dljsjr dljsjr requested review from ctowns and lelandblue July 22, 2024 18:58
@github-actions GitHub Actions
Copy link

Test Results

   60 files    377 suites   0s ⏱️
1 827 tests 1 827 ✅ 0 💤 0 ❌
3 176 runs  3 176 ✅ 0 💤 0 ❌

Results for commit 545862c.

@github-actions GitHub Actions
Copy link

File Coverage
All files 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 545862c

lelandblue
lelandblue approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@lelandblue lelandblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Doug - please proceed with Merging.

@dljsjr dljsjr merged commit 562da89 into beta Jul 22, 2024
11 checks passed
@dljsjr dljsjr deleted the beta-hotfix/wwst-matter-switch-fingerprints branch July 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lelandblue lelandblue lelandblue approved these changes

@ctowns ctowns Awaiting requested review from ctowns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dljsjr @lelandblue @ctowns