Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter Switch: add missing quotes around fingerprint id #1539

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Jul 22, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adds quotes around fingerprint ID from fingerprint introduced here: #1530

Summary of Completed Tests

@ctowns ctowns mentioned this pull request Jul 22, 2024
13 tasks
Copy link

Test Results

   60 files  ±0    377 suites  ±0   0s ⏱️ ±0s
1 828 tests ±0  1 828 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 177 runs  ±0  3 177 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1f7c99c. ± Comparison against base commit f40bbd1.

Copy link

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 1f7c99c

Copy link

github-actions bot commented Jul 22, 2024

Channel deleted.

@ctowns ctowns merged commit 37e689a into main Jul 22, 2024
11 checks passed
@ctowns ctowns deleted the add-missing-quotes branch July 22, 2024 20:26
@lelandblue
Copy link
Contributor

Thank you Cooper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants