Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling up Main to Beta #1540

Merged
merged 10 commits into from
Jul 22, 2024
Merged

Rolling up Main to Beta #1540

merged 10 commits into from
Jul 22, 2024

Conversation

dljsjr
Copy link
Contributor

@dljsjr dljsjr commented Jul 22, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor
  • Release

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Rolling up main to beta

Summary of Completed Tests

N/A

seojune79 and others added 9 commits July 15, 2024 16:28
@seojune79
[Aqara/Roller Shade] change the way windowShadeLevel capability updat…
c0b8196 
…es (#1494)

* change the way windowShadeLevel capability updates

* change open and close command handlers

* modified windowShadeLevel update process and added new test case
@HunsupJung
Add device configuration for matter-fan (#1460)
c5c28ec 
Signed-off-by: Hunsup Jung <[email protected]>
@lelandblue
Edge Driver Repo Check List (#1058)
f6e3f64 
* Edge Driver Repo Check List

This is a potential sample for a PR Template for the Edge Drivers Repo.

* Update Checklist

* Update Checklist

* Update Checklist

* Rename Checklist to PULL_REQUEST_TEMPLATE

Change file name to PULL_REQUEST_TEMPLATE

* Update PULL_REQUEST_TEMPLATE

* Update PULL_REQUEST_TEMPLATE

* Update PULL_REQUEST_TEMPLATE

* Update and rename PULL_REQUEST_TEMPLATE to .github/PULL_REQUEST_TEMPLATE.md

Relocate and change file type

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md
@ctowns
Remove embedded clusters from CI coverage results (#1528)
507d4ab 
* Remove embedded clusters from CI coverage results
Co-authored-by: Harrison Carter <[email protected]>
@lelandblue
New Device (Matter Switch) Orein OS0100411267 (#1530)
2a586eb 
* new-device-AiDot-Orein- OS0100411267

* Adding additional Fingerprint for Linkind device

* Adding additional fingerprint for the Oriein OS01006110
@ctowns @lelandblue
Matter Switch: new fingerprint for Cync Full Color A19 (#1514)
da872e5 
Co-authored-by: Alissa Dornbos <[email protected]>
@lelandblue
New Devices (Matter Switch) Cync Bulbs and Winees Plug (#1531)
f40bbd1 
* new-devices-for-Cync-and-Winees

* Adding additional Fingerprint for 

Additional PR to add another recently opened WWST CERT request for a Cync Full Color A19, ModelNumber: CLEDA199CD1MS.  

vendorId: 0x1339
productId: 0x0015

I could not confirm the Matter Device Type ID

* Fix a bad commit

Removed a dupe fingerprint and added the following fingerprint. 

- id: 4921/107
  deviceLabel: Cync Reveal Full Color A19
  vendorId: 0x1339
  productId: 0x006B
  deviceProfileName: light-color-level-2000K-7000K

* Adding missed quotes around product ID
@ctowns
Matter Switch: add missing quotes around fingerprint id
1f7c99c
@ctowns
Merge pull request #1539 from SmartThingsCommunity/add-missing-quotes
37e689a 
Matter Switch: add missing quotes around fingerprint id
@github-actions GitHub Actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

Test Results

   60 files  ±0    377 suites  ±0   0s ⏱️ ±0s
1 828 tests +1  1 828 ✅ +1  0 💤 ±0  0 ❌ ±0 
3 177 runs  +1  3 177 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 23deab7. ± Comparison against base commit 562da89.

@github-actions GitHub Actions
Copy link

matter-switch_coverage.xml

File Coverage
All files 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% ✅

matter-thermostat_coverage.xml

File Coverage
All files 80% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% ❌

zigbee-window-treatment_coverage.xml

File Coverage
All files 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/aqara/aqara_utils.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/aqara/init.lua 79% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/somfy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/hanssem/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/vimar/init.lua 50% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/aqara/roller-shade/init.lua 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/invert-lift-percentage/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/axis/axis_version/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/yoolax/init.lua 94% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 23deab7

@dljsjr dljsjr merged commit 2153462 into beta Jul 22, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctowns ctowns ctowns approved these changes

@greens greens Awaiting requested review from greens

@cjswedes cjswedes Awaiting requested review from cjswedes

@lelandblue lelandblue Awaiting requested review from lelandblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dljsjr @ctowns @seojune79 @HunsupJung @lelandblue