Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile for the IKEA air purifier #1542

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Jul 24, 2024

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This change adds a profile to support all of the attributes supported by the STARKVIND air purifier device. Additionally, the PM2.5 measurement attribute is added as a subscribed attribute.

CHAD-13730

Summary of Completed Tests

Tested on a STARKVIND air purifier device. All capabilities display correctly in the ST app and all functionality works as expected.

Sorry, something went wrong.

This change adds a profile to supports all of the attributes supported
by the STARKVIND air purifier device. Additionally, the PM2.5
measurement attribute is added as a subscribed attribute.
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Jul 24, 2024

Channel deleted.

Copy link

github-actions bot commented Jul 24, 2024

Test Results

   61 files    375 suites   0s ⏱️
1 820 tests 1 820 ✅ 0 💤 0 ❌
3 169 runs  3 169 ✅ 0 💤 0 ❌

Results for commit 598c532.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 24, 2024

File Coverage
All files 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 82%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 598c532

Copy link
Contributor

@tpmanley tpmanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have this device to test with but the capabilities in the new profile look right

@nickolas-deboom nickolas-deboom merged commit 7eaeae2 into main Aug 7, 2024
12 checks passed
@nickolas-deboom nickolas-deboom deleted the add-profile-for-ikea-air-purifier branch August 7, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants