Production Edge Driver PR for 29-July-2024 #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (#1494) * change the way windowShadeLevel capability updates * change open and close command handlers * modified windowShadeLevel update process and added new test case
Signed-off-by: Hunsup Jung <[email protected]>
* Edge Driver Repo Check List This is a potential sample for a PR Template for the Edge Drivers Repo. * Update Checklist * Update Checklist * Update Checklist * Rename Checklist to PULL_REQUEST_TEMPLATE Change file name to PULL_REQUEST_TEMPLATE * Update PULL_REQUEST_TEMPLATE * Update PULL_REQUEST_TEMPLATE * Update PULL_REQUEST_TEMPLATE * Update and rename PULL_REQUEST_TEMPLATE to .github/PULL_REQUEST_TEMPLATE.md Relocate and change file type * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md
* Remove embedded clusters from CI coverage results Co-authored-by: Harrison Carter <[email protected]>
* new-device-AiDot-Orein- OS0100411267 * Adding additional Fingerprint for Linkind device * Adding additional fingerprint for the Oriein OS01006110
Co-authored-by: Alissa Dornbos <[email protected]>
* new-devices-for-Cync-and-Winees * Adding additional Fingerprint for Additional PR to add another recently opened WWST CERT request for a Cync Full Color A19, ModelNumber: CLEDA199CD1MS. vendorId: 0x1339 productId: 0x0015 I could not confirm the Matter Device Type ID * Fix a bad commit Removed a dupe fingerprint and added the following fingerprint. - id: 4921/107 deviceLabel: Cync Reveal Full Color A19 vendorId: 0x1339 productId: 0x006B deviceProfileName: light-color-level-2000K-7000K * Adding missed quotes around product ID
Matter Switch: add missing quotes around fingerprint id
Revert (Zigbee Window Treatment) Aqara/Roller Shade PR 1494
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 60 files 377 suites 0s ⏱️ Results for commit e48ae8b. |
|
matter-switch_coverage.xml
matter-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against e48ae8b |
ctowns
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Looks good to me, but I'm not sure why the Delete PR channel check is being shown here. It looks like that CI check was run 4 hours ago for #1544 but for some reason it is showing up here. It looks like the PR channel for #1544 is still open so I think we'd just need to run the delete channel task again and it should be resolved. @greens have we seen the delete channel task show up on a different PR before?
greens
approved these changes
Jul 29, 2024
|
@ctowns nope! Not sure why that happened but I suspect github weirdness. |
ctowns
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is the PR to start the production release for 29-July-2024.