Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

29-July-24 Production Deploy Main to Beta #1552

Merged
merged 3 commits into from
Jul 29, 2024
Merged

29-July-24 Production Deploy Main to Beta #1552

merged 3 commits into from
Jul 29, 2024

Conversation

lelandblue
Copy link
Contributor

Description of Change

This PR is for the Production deploy to move changes in Main to the Beta channel.

HunsupJung and others added 3 commits July 25, 2024 11:12
@HunsupJung
Set state_change to true when receive lockAlarm event (#1519)
8591347 
Signed-off-by: Hunsup Jung <[email protected]>
@nickolas-deboom
Revert dynamic constraint updates for matter-thermostat and matter-se…
d5ec70c 
…nsor (#1455)

A bug exists in the hub firmware that needs to be corrected before
temperature conversions for the setpoint limits will work. Therefore,
this PR will revert the dynamic constraint updates originally made in PR
1223 until the bug is fixed in the next firmware release.
@lelandblue
Merge pull request #1544 from SmartThingsCommunity/beta
c18a6de 
Rolling Down Beta to Main
@github-actions GitHub Actions
Copy link

Test Results

   60 files  ±0    375 suites   - 2   0s ⏱️ ±0s
1 820 tests  - 7  1 820 ✅  - 7  0 💤 ±0  0 ❌ ±0 
3 168 runs   - 8  3 168 ✅  - 8  0 💤 ±0  0 ❌ ±0 

Results for commit c18a6de. ± Comparison against base commit e48ae8b.

This pull request removes 7 tests. 
Min and max cooling setpoint attributes do not set capability constraint for RPC version less than 4
Min and max cooling setpoint attributes set capability constraint
Min and max heating setpoint attributes do not set capability constraint for RPC version less than 4
Min and max heating setpoint attributes set capability constraint
Min and max temperature attributes do not set capability constraint for RPC version less than 4
Min and max temperature attributes do not set capability constraint when RPC version is less than 4
Min and max temperature attributes set capability constraint

@github-actions GitHub Actions
Copy link

matter-lock_coverage.xml

File Coverage
All files 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% ✅

matter-sensor_coverage.xml

File Coverage
All files 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91% ✅

matter-thermostat_coverage.xml

File Coverage
All files 80% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 82% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against c18a6de

@lelandblue lelandblue merged commit b05b65b into beta Jul 29, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctowns ctowns ctowns approved these changes

@greens greens greens approved these changes

@nickolas-deboom nickolas-deboom Awaiting requested review from nickolas-deboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lelandblue @greens @ctowns @HunsupJung @nickolas-deboom