-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aqara smart wall switch T1 #1562
Conversation
Channel deleted. |
Test Results 61 files + 1 379 suites +4 0s ⏱️ ±0s Results for commit 770ebc7. ± Comparison against base commit e3ce14d. This pull request removes 1 and adds 34 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 770ebc7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good! Just a quick question regarding the deviceLabel
that shouldn't hold this PR from merging 👍
model: lumi.switch.b1nacn01 | ||
deviceProfileName: aqara-switch-power | ||
- id: "LUMI/lumi.switch.b2nacn01" | ||
deviceLabel: Aqara Smart Wall Switch T1 (With Neutral, Double Rocker) 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me why the 1
is needed on the end of the device label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer here
* Aqara smart wall switch T1 * added space for device name
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests