Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqara smart wall switch T1 #1562

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

Hongming6
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Copy link

github-actions bot commented Aug 7, 2024

Channel deleted.

Copy link

github-actions bot commented Aug 7, 2024

Test Results

   61 files  + 1    379 suites  +4   0s ⏱️ ±0s
1 853 tests +33  1 853 ✅ +33  0 💤 ±0  0 ❌ ±0 
3 209 runs  +40  3 209 ✅ +40  0 💤 ±0  0 ❌ ±0 

Results for commit 770ebc7. ± Comparison against base commit e3ce14d.

This pull request removes 1 and adds 34 tests. Note that renamed tests count towards both.
Handle received Lock State from Matter device.
Battery voltage report should be handled, 48
Capability on command should be handled : child lock locked
Capability on command should be handled : thermostat mode manual
Capability on command should be handled : valve Calibration
Capability on command should be handled : valve open
Child device profiles should be overriden for specific devices
Handle BatChargeLevel capability handling with batteryLevel.
Handle antifreezeModeSetting in infochanged
Handle notificationOfValveTest in infochanged
Handle received LockState.LOCKED from Matter device.
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 7, 2024

File Coverage
All files 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/vimar/init.lua 70%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/enbrighten-metering-dimmer/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/multi-switch/init.lua 87%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/ge-link-bulb/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/init.lua 73%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/jasco/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/wallhero/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/aurora-relay/init.lua 80%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 770ebc7

Copy link
Contributor

@wkhenon wkhenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good! Just a quick question regarding the deviceLabel that shouldn't hold this PR from merging 👍

model: lumi.switch.b1nacn01
deviceProfileName: aqara-switch-power
- id: "LUMI/lumi.switch.b2nacn01"
deviceLabel: Aqara Smart Wall Switch T1 (With Neutral, Double Rocker) 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me why the 1 is needed on the end of the device label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1384 (review)

Please refer here

@lelandblue lelandblue added the WWST label Sep 6, 2024
@lelandblue lelandblue merged commit 6195576 into SmartThingsCommunity:main Sep 10, 2024
15 checks passed
HunsupJung pushed a commit that referenced this pull request Sep 27, 2024
* Aqara smart wall switch T1

* added space for device name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants