Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCS-5080] Change hardwareType used for hub fingerprints #1566

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

nathankooistra
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Changed hub driver fingerprints - specifically the hardwareType used by the tv-hub and soundbar-hub.

Summary of Completed Tests

Copy link

github-actions bot commented Aug 8, 2024

Channel deleted.

Copy link

github-actions bot commented Aug 8, 2024

Test Results

   61 files    375 suites   0s ⏱️
1 820 tests 1 820 ✅ 0 💤 0 ❌
3 169 runs  3 169 ✅ 0 💤 0 ❌

Results for commit 1e7e09e.

Copy link

github-actions bot commented Aug 8, 2024

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 1e7e09e

@nathankooistra nathankooistra merged commit dc2d4c7 into main Aug 8, 2024
11 checks passed
@nathankooistra nathankooistra deleted the hcs-5080-hardwareTypes branch August 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants