Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter Bridge Aqara Cube Support with Custom Capability #1570

Closed
wants to merge 1 commit into from
Closed

Conversation

DongHoon-Ryu
Copy link
Contributor

Currently, the Generic EdgeDriver applied to the Matter Bridge Aqara Cube is implemented by mapping six faces into individual components, making it difficult to check the event occurrence of individual faces on one screen.

  • REQ-15926, REQ-16285, IOTE-4217, IOTE-4266

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • [V] Refactor

Checklist

  • [V] I have performed a self-review of my code
  • [V] I have commented my code in hard-to-understand areas
  • [V] I have verified my changes by testing with a device or have communicated a plan for testing
  • [V] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

  • This commit wants to improve the problem by mapping the event from Matter Bridge with Aqara Cube Custom Capability developed by Zigbee. This means that there is a limitation that the Action Event of the Cube that the Matter Bridge does not give can not be processed.

Summary of Completed Tests

  • Successful test for Plugin UI update and Dash Board's Device Card status update according to the selection of each face
  • Successful Automation Routine Test for Cube Face
  • Even though the Cube Face is changed, the status is sometimes not updated because the Aqara Matter Bride does not send the event.

Currently, the Generic EdgeDriver applied to the Matter Bridge Aqara Cube is implemented by mapping six faces into individual components,
making it difficult to check the event occurrence of individual faces on one screen.

So this commit wants to improve the problem by mapping the event from Matter Bridge with Aqara Cube Custom Capability developed by Zigbee.
This means that there is a limitation that the Action Event of the Cube that the Matter Bridge does not give can not be processed.

 - REQ-15926, REQ-16285, IOTE-4217, IOTE-4266

Signed-off-by: donghoon-ryu <[email protected]>
Copy link

github-actions bot commented Aug 9, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Aug 9, 2024

Channel deleted.

Copy link

github-actions bot commented Aug 9, 2024

Test Results

   61 files    375 suites   0s ⏱️
1 821 tests 1 821 ✅ 0 💤 0 ❌
3 170 runs  3 170 ✅ 0 💤 0 ❌

Results for commit bded3e5.

Copy link

github-actions bot commented Aug 9, 2024

File Coverage
All files 70%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/aqara-cube/init.lua 33%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against bded3e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant