Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rolling up main to beta #1585

Merged
merged 2 commits into from
Aug 19, 2024
Merged

rolling up main to beta #1585

merged 2 commits into from
Aug 19, 2024

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Aug 16, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor
  • Release

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

ctowns added 2 commits August 16, 2024 11:39
Matter Switch: add child profile overrides

Add the ability to override the child profile that would be assigned
based on the child's device type. This is done because some devices
have the "On/Off Plug" device type, but it would make more sense
for them to appear with the switch icon as indicated in their
WWST fingerprint.
Sometime invalid hue and saturation values outside the range [0,100]
can be received from the app. This adds a clamp to make sure values
we send to the device are within the spec range of [0,254]
Copy link

github-actions bot commented Aug 16, 2024

Channel deleted.

Copy link

Test Results

   61 files    375 suites   0s ⏱️
1 823 tests 1 823 ✅ 0 💤 0 ❌
3 171 runs  3 171 ✅ 0 💤 0 ❌

Results for commit cb1f617.

Copy link

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against cb1f617

@lelandblue
Copy link
Contributor

@ctowns Please complete the checklist

@cjswedes cjswedes self-requested a review August 19, 2024 16:35
Copy link
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctowns ctowns merged commit 1bd918b into beta Aug 19, 2024
106 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants