Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release beta to production #1590

Merged
merged 28 commits into from
Aug 19, 2024
Merged

Release beta to production #1590

merged 28 commits into from
Aug 19, 2024

Conversation

cjswedes
Copy link
Contributor

No description provided.

chenpeixiang and others added 28 commits May 31, 2024 11:26
[HCS-5080] Add hub drivers for TV, Fridge, Soundbar, and all other types
This change adds a profile to supports all of the attributes supported
by the STARKVIND air purifier device. Additionally, the PM2.5
measurement attribute is added as a subscribed attribute.
New Devices (AiDot Matter Color Temperature Light) for Certification
New Device (Matter Thermostat) Eve Thermostat
…ypes

[HCS-5080] Change hardwareType used for hub fingerprints
Permit and create a new series of optional profiles for room ac
…ication_HCS5008

HCS5008 - Remove AudioNotification Capability for samsung-audio driver
only switch and switchLevel capabilities will be supported for Matter,
Zigbee, and Z-Wave devices in the 0.54.x firmware. Using this
functionality give a huge latency improvement for handling these
capability commands which is important when a driver is handling several
commands all at once (i.e. a routine is triggered that toggles a bunch
of switches)
…ive-handlers

Enable native handlers for drivers that can use them
There are some 5-button Matter devices out there so the addition of the
5-button profiles will allow those devices to join as a single multi-component
device instead of a parent/child device.

https://smartthings.atlassian.net/browse/CHAD-13761
Matter Button: Add profile for 5-button devices
Moving Main to Beta to support WWST Cync Indoor Plug CPLGSTDBLW1MS Early
Matter Switch: add child profile overrides

Add the ability to override the child profile that would be assigned
based on the child's device type. This is done because some devices
have the "On/Off Plug" device type, but it would make more sense
for them to appear with the switch icon as indicated in their
WWST fingerprint.
Sometime invalid hue and saturation values outside the range [0,100]
can be received from the app. This adds a clamp to make sure values
we send to the device are within the spec range of [0,254]
@cjswedes cjswedes requested review from greens and ctowns August 19, 2024 17:05
@cjswedes cjswedes requested a review from lelandblue August 19, 2024 17:05
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 10 committers have signed the CLA.

✅ chenpeixiang
✅ lelandblue
✅ dljsjr
✅ nathankooistra
✅ hcarter-775
✅ tpmanley
✅ cjswedes
✅ ctowns
✅ nickolas-deboom
❌ satyajitanand
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Duplicate profile check: Warning - duplicate profiles detected.
hub-thing.yml == refrigerator-hub.yml
hub-thing.yml == soundbar-hub.yml
hub-thing.yml == tv-hub.yml
refrigerator-hub.yml == soundbar-hub.yml
refrigerator-hub.yml == tv-hub.yml
soundbar-hub.yml == tv-hub.yml

Copy link

Test Results

   61 files    375 suites   0s ⏱️
1 823 tests 1 823 ✅ 0 💤 0 ❌
3 171 runs  3 171 ✅ 0 💤 0 ❌

Results for commit 1bd918b.

Copy link

matter-button_coverage.xml

File Coverage
All files 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92%

matter-switch_coverage.xml

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%

matter-thermostat_coverage.xml

File Coverage
All files 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 83%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 1bd918b

@ctowns
Copy link
Contributor

ctowns commented Aug 19, 2024

Duplicate profile check: Warning - duplicate profiles detected. hub-thing.yml == refrigerator-hub.yml hub-thing.yml == soundbar-hub.yml hub-thing.yml == tv-hub.yml refrigerator-hub.yml == soundbar-hub.yml refrigerator-hub.yml == tv-hub.yml soundbar-hub.yml == tv-hub.yml

Created ticket to address this here: https://smartthings.atlassian.net/browse/CHAD-13826

We can ignore this warning for now as these profiles are different but the script is just incorrectly marking them as duplicates due to a missed check in the script for the new config values.

@cjswedes cjswedes merged commit ce4c5b3 into production Aug 19, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.