Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling up beta to production #1599

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Rolling up beta to production #1599

merged 2 commits into from
Aug 26, 2024

Conversation

cbaumler
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

lelandblue and others added 2 commits August 26, 2024 11:50
@lelandblue @ctowns @cbaumler
New Device (Matter Lock) Aqara U300 (#1557)
6ecec3f 
* new-device-Matter-Lock-Aqara-U300

* Matter Lock: add Aqara U300 to Aqara Lock sub driver

* Remove product ID from aqara-lock sub driver, use vendor id only

---------

Co-authored-by: Cooper Towns <[email protected]>
@cbaumler
Merge pull request #1598 from SmartThingsCommunity/beta-hotfix/WWSTCE…
3a72f33 
…RT-3390

Cherry-pick WWSTCERT-3390 into Beta ahead of production
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

Test Results

   61 files    375 suites   0s ⏱️
1 823 tests 1 823 ✅ 0 💤 0 ❌
3 171 runs  3 171 ✅ 0 💤 0 ❌

Results for commit 3a72f33.

@github-actions GitHub Actions
Copy link

File Coverage
All files 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3a72f33

@cbaumler cbaumler merged commit 72e2f56 into production Aug 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@lelandblue lelandblue lelandblue approved these changes

@ctowns ctowns ctowns approved these changes

@greens greens Awaiting requested review from greens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cbaumler @CLAassistant @ctowns @lelandblue @hcarter-775