Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling up main into beta #1600

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Rolling up main into beta #1600

merged 5 commits into from
Aug 26, 2024

Conversation

cbaumler
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

hcarter-775 and others added 5 commits August 20, 2024 15:37
@hcarter-775
CHAD 13147: Matter Sensor Driver Profiles Cleanup (#1466)
11bf263 
* remove matter-motion and fix fingerprint to outdated profile
@hcarter-775
Matter Thermostat: clamp percentage values (#1592)
ec3c3ff 
* add: clamp on percent handler
@lelandblue @ctowns
New Device (Matter Lock) Aqara U300 (#1557)
cc00516 
* new-device-Matter-Lock-Aqara-U300

* Matter Lock: add Aqara U300 to Aqara Lock sub driver

* Remove product ID from aqara-lock sub driver, use vendor id only

---------

Co-authored-by: Cooper Towns <[email protected]>
@tpmanley
matter-lock: Expose 'not fully locked' when reported by the lock
1caa657 
Previously we were mapping the 'not fully locked' to 'unknown' but now that
the lock attribute has the 'not fully locked' variant we can expose that
directly.

https://smartthings.atlassian.net/browse/CHAD-11259
@tpmanley
Merge pull request #1595 from SmartThingsCommunity/feature/lock-notfu…
5bd9bbd 
…llylocked

matter-lock: Expose 'not fully locked' when reported by the lock
@github-actions GitHub Actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

Test Results

   61 files  ±0    375 suites  ±0   0s ⏱️ ±0s
1 827 tests +4  1 827 ✅ +4  0 💤 ±0  0 ❌ ±0 
3 177 runs  +6  3 177 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 5bd9bbd. ± Comparison against base commit 3a72f33.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. 
Handle received Lock State from Matter device.

Handle received LockState.LOCKED from Matter device.
Handle received LockState.NOT_FULLY_LOCKED from Matter device.
Handle received LockState.UNLATCHED from Matter device.
Handle received LockState.UNLOCKED from Matter device.
Set percent command should clamp invalid percentage values

@github-actions GitHub Actions
Copy link

matter-lock_coverage.xml

File Coverage
All files 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% ✅

matter-sensor_coverage.xml

File Coverage
All files 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91% ✅

matter-thermostat_coverage.xml

File Coverage
All files 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 5bd9bbd

@cbaumler cbaumler merged commit a4529e9 into beta Aug 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctowns ctowns ctowns approved these changes

@greens greens Awaiting requested review from greens

@lelandblue lelandblue Awaiting requested review from lelandblue

@hcarter-775 hcarter-775 Awaiting requested review from hcarter-775

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cbaumler @ctowns @hcarter-775 @lelandblue @tpmanley