-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batteryLevel capability to the matter lock driver #1608
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Channel deleted. |
Test Results 61 files 379 suites 0s ⏱️ Results for commit fce3333. ♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against fce3333 |
drivers/SmartThings/matter-lock/profiles/base-lock-batteryLevel.yml
Outdated
Show resolved
Hide resolved
These changes look good to me except I don't see logic in the driver that would cause a device to join the new profiles based on its supported capabilities - I'm just wondering how the new profiles would get selected? |
@nickolas-deboom yeah, right now there's not really any complex configuration logic in matter-lock, so the only way that most profiles in this driver (the new ones included) can be used is with manual WWST fingerprinting. There is some action item open about redoing this logic but for now, that's what we have. For example, the WWST device that tested with these changes was fingerprinted with one of the new profiles. |
drivers/SmartThings/matter-lock/src/test/test_matter_lock_batteryLevel.lua
Show resolved
Hide resolved
drivers/SmartThings/matter-lock/src/test/test_matter_lock_batteryLevel.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/matter-lock/src/test/test_matter_lock_batteryLevel.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/matter-lock/profiles/lock-without-codes-batteryLevel.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Is there a ticket for the eventual dynamic configuration of battLev devices?
Yes, there is. See this ticket. It's pretty barebones but it's on the docket. |
Check all that apply
Type of Change
Checklist
Description of Change
Jira Ticket: https://smartthings.atlassian.net/browse/CHAD-13915
batteryLevel is a capability that was added for Matter 1.2, and is useful for cases where the BatPercentRemaining attribute of the PowerSource cluster does not exist, but the BatChargeLevel attribute does.
Summary of Completed Tests
A real-life device example: https://smartthings.atlassian.net/browse/WWSTCERT-3507