Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rolling up main to beta #1637

Merged
merged 5 commits into from
Sep 16, 2024
Merged

rolling up main to beta #1637

merged 5 commits into from
Sep 16, 2024

Conversation

nickolas-deboom
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor
  • Release

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Detailzc and others added 5 commits September 11, 2024 15:52
@Detailzc
Add Aqara Cube T1 Pro corresponding chinese name (#1618)
71a1c62 
Signed-off-by: WangShao <[email protected]>
@hcarter-775
Update Github Actions Artifacts version (#1630)
b5808a0 
Update the GA Artifacts version
@seojune79
[Aqara] Presence Sensor FP2 (#1546)
d2f9765 
* add Aqara FP2

* add search-parameters.yml

* Modify "device:supports_capability" parameter

* fix luacheck fail

* Fixed minor issues

* fix zone name initialization

* Change find_new_connetion to find_new_connection

* Fixed zone name initialization issue

* fix luacheck fail

* Modified some code based on comments
@nickolas-deboom
Matter Thermostat and Sensor: Reimplement dynamic constraints (#1619)
222c8d2 
Matter Thermostat and Sensor: Reimplement dynamic constraints
@lelandblue
New Devices (Matter Switch) AiDot Orein St58CCT Bulbs (#1633)
0706571 
* New Devices Aidot ST58CCT

* Removing extra white space

* Adding quotes for new fingerprints
@github-actions GitHub Actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Test Results

   62 files  +1    383 suites  +2   0s ⏱️ ±0s
1 862 tests +7  1 862 ✅ +7  0 💤 ±0  0 ❌ ±0 
3 249 runs  +8  3 249 ✅ +8  0 💤 ±0  0 ❌ ±0 

Results for commit 0706571. ± Comparison against base commit 4a2ba14.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

matter-sensor_coverage.xml

File Coverage
All files 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% ❌

matter-switch_coverage.xml

File Coverage
All files 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% ✅

matter-thermostat_coverage.xml

File Coverage
All files 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0706571

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Channel deleted.

@nickolas-deboom nickolas-deboom merged commit 4aa8f76 into beta Sep 16, 2024
61 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@ctowns ctowns ctowns approved these changes

@lelandblue lelandblue Awaiting requested review from lelandblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nickolas-deboom @ctowns @hcarter-775 @Detailzc @seojune79 @lelandblue