Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAD-13777 Allow virtual device events to not always be a state change #1639

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

greens
Copy link
Contributor

@greens greens commented Sep 16, 2024

Adds a new certified preference 'forceStateChange' that allows users to select whether they want their virtual device events to always be a state change or not.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Adds a new certified preference 'forceStateChange' that allows users to select whether they want their virtual device events to always be a state change or not.
@greens greens requested a review from kdbang September 16, 2024 22:42
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@greens greens requested a review from wkhenon September 16, 2024 22:43
Copy link

Test Results

   62 files  ±0    383 suites  ±0   0s ⏱️ ±0s
1 863 tests +1  1 863 ✅ +1  0 💤 ±0  0 ❌ ±0 
3 250 runs  +1  3 250 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 13fa587. ± Comparison against base commit 0706571.

Copy link

File Coverage
All files 100%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 13fa587

@kdbang
Copy link
Collaborator

kdbang commented Sep 30, 2024

sorry for late.
looks good to me.

@greens greens merged commit b2893b0 into main Sep 30, 2024
12 checks passed
@greens greens deleted the feature/CHAD-13777 branch September 30, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants