-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter 1.3 Driver Release #1640
Conversation
Duplicate profile check: Warning - duplicate profiles detected. |
Test Results 63 files 395 suites 0s ⏱️ Results for commit f125ceb. ♻️ This comment has been updated with latest results. |
matter-appliance_coverage.xml
matter-evse_coverage.xml
matter-sensor_coverage.xml
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against f125ceb |
Channel deleted. |
drivers/SmartThings/matter-evse/profiles/evse-energy-power-meas-energy-mgmt-mode.yml
Outdated
Show resolved
Hide resolved
@nickolas-deboom can we get the unit test coverage for extractor-hood above 90%?
|
drivers/SmartThings/matter-appliance/src/embedded-cluster-utils.lua
Outdated
Show resolved
Hide resolved
@nickolas-deboom in your latest commit, you removed the setting of the CURRENT_CONFIGURED_UNIT field. Was this purposeful? |
After some discussion with the team, we realized that the logic in matter-oven to emit the capabilities with degF would allow the proper temperature units to display for hubs that are on firmware lower than 54. I added it back, with a check for the RPC version. Note that RPC >= 5 corresponds to hubcore FW >= 54. Sorry for the confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @hcarter-775, @ctowns, @nickolas-deboom and @HunsupJung!
Since the commit history is being squashed (+building upon original PR) and this is a multi-member effort, let's attribute the authors (Cooper, Nick, Hunsup and any others who I'm missing) appropriately in the final commit
drivers/SmartThings/matter-appliance/profiles/cook-surface-one-tl-cook-surface-two-tl.yml
Outdated
Show resolved
Hide resolved
...ngs/matter-appliance/src/ActivatedCarbonFilterMonitoring/server/attributes/AttributeList.lua
Outdated
Show resolved
Hide resolved
d1dee85
to
6d14ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be needed for MVP, but each of the matter appliance drivers should be updated to use a version of the find_default_endpoint()
function rather than using the MATTER_DEFAULT_ENDPOINT
value for all the endpoint defaults. The return value from the find_default_endpoints()
function should return the the first endpoint that supports one of the device type's mandatory clusters. This is important for cases where the device is bridged and the default endpoint is not 1.
You can see an example in the matter-thermostat
driver here:
local function find_default_endpoint(device, cluster) |
cc: @HunsupJung
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments but I do not think they are anything that should block moving forward with the beta release next week. Consider this my approval pending resolution of the following item:
There is still a pending discussion around handling the temperatureSetpoint
that needs to be resolved that could impact how we move forward with the appliance drivers that support this capability.
As discussed, we decided to only emit the |
drivers/SmartThings/matter-evse/src/test/test_evse_energy_meas.lua
Outdated
Show resolved
Hide resolved
Signed-off-by: Hunsup Jung <[email protected]>
Signed-off-by: Hunsup Jung <[email protected]>
handling * The setpoint range capability is gated on the RPC version to ensure that it is only emitted for hubs on firmware 54 or above. Temperature conversion is not supported for lower firmware versions. * Remove degF handling.
93a326f
to
f125ceb
Compare
Check all that apply
Type of Change
Checklist
Description of Change
New Device Types Included:
Water Valve
Rain Sensor
Leak Detector
Freeze Detector
Water Valve
Electrical Sensor
EVSE
Laundry Dryer
Extractor Hood
Microwave Oven
Oven
Cooktop
Also includes:
Embedded Matter 1.3 clusters, cluster utils
Updated .luacov file (CI support)
Small updates to Refrigerator, Dishwasher drivers
Small updates to resolve changes since this PR's creation
See Completed Testing and Updates of Non-driver specific work here:
https://smartthings.atlassian.net/wiki/spaces/CHIP/pages/3434446937/Matter+1.3+Release+Preparations
Summary of Completed Tests