Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Devices (Matter Switch) LetainPai Smart Switch(s) #1649

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

lelandblue
Copy link
Contributor

Check all that apply

Type of Change

  • [ X] WWST Certification Request
  • Bug fix
  • New feature
  • Refactor

Checklist

  • [ X ] I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding fingerprints for Three CN Certification Request for Matter Switch Devices. All devices are in the DCL with a device type of x103.
LeTianPai Smart Switch(with Neutral) 3 Gangs
LeTianPai Smart Switch(with Neutral) 2 Gangs
LeTianPai Smart Switch(with Neutral) 1 Gang

I will also reach out regarding translations of this device, but I believe this can move forward.

Summary of Completed Tests

I believe this will be further tested in CN.

Copy link

github-actions bot commented Sep 26, 2024

Channel deleted.

Copy link

github-actions bot commented Sep 26, 2024

Test Results

   63 files    395 suites   0s ⏱️
1 932 tests 1 932 ✅ 0 💤 0 ❌
3 356 runs  3 356 ✅ 0 💤 0 ❌

Results for commit 4a006d3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 26, 2024

File Coverage
All files 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 4a006d3

There was feedback provided from the partner that they wanted updated Device Labels, so that feedback is being incorporated in this commit.
@lelandblue lelandblue merged commit 0d7bee2 into main Sep 30, 2024
11 checks passed
@lelandblue lelandblue deleted the New-devices-LeTainpai-Switches branch September 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants