Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new matter lock tom #1664

Closed
wants to merge 2 commits into from

Conversation

tpmanley
Copy link
Contributor

@tpmanley tpmanley commented Oct 2, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Copy link

github-actions bot commented Oct 2, 2024

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/eGM6d71yPelA

Copy link

github-actions bot commented Oct 2, 2024

Test Results

   62 files   -  1    384 suites   - 11   0s ⏱️ ±0s
1 864 tests  - 70  1 843 ✅  -  91  0 💤 ±0  21 ❌ +21 
3 267 runs   - 91  3 246 ✅  - 112  0 💤 ±0  21 ❌ +21 

For more details on these failures, see this check.

Results for commit fadd89c. ± Comparison against base commit 1b19d30.

This pull request removes 70 tests.
Active power measurement should generate correct messages
Assert component to endpoint map
Assert profile applied over doConfigure
Boolean state freeze detection reports should generate correct messages
Boolean state leak detection reports should generate correct messages
Boolean state rain detection reports should generate correct messages
Check that preference updates to high after being set on-device as expected
Check that preference updates to high as expected
Check that preference updates to low as expected
Close command should send the appropriate commands
…

Copy link

github-actions bot commented Oct 2, 2024

File Coverage
All files 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 69%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 29%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against fadd89c

@tpmanley tpmanley closed this Oct 7, 2024
@tpmanley tpmanley deleted the feature/new-matter-lock-tom branch October 7, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant