Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick to beta #1667

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Cherry pick to beta #1667

merged 1 commit into from
Oct 7, 2024

Conversation

cjswedes
Copy link
Contributor

@cjswedes cjswedes commented Oct 7, 2024

Cherry pick #1661 so it makes it to production today.

@cjswedes cjswedes requested review from greens and lelandblue October 7, 2024 19:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/pbMva4m5v6jO

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Test Results

   63 files    395 suites   0s ⏱️
1 934 tests 1 934 ✅ 0 💤 0 ❌
3 358 runs  3 358 ✅ 0 💤 0 ❌

Results for commit f7ce338.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

File Coverage
All files 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against f7ce338

@cjswedes cjswedes changed the title New Device IM Pushbutton Module Cherry pick to beta Oct 7, 2024
@cjswedes cjswedes requested a review from hcarter-775 October 7, 2024 19:35
lelandblue
lelandblue approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@lelandblue lelandblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that this is the only necessary change that needs to go to Beta in advance of the Production default release.

@cjswedes cjswedes merged commit e262085 into beta Oct 7, 2024
11 checks passed
@cjswedes cjswedes deleted the cherry-pick-10/7 branch October 7, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lelandblue lelandblue lelandblue approved these changes

@greens greens Awaiting requested review from greens

@hcarter-775 hcarter-775 Awaiting requested review from hcarter-775

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjswedes @lelandblue