-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bar 300] Issues - device don't operate about 'stop' command #1797
base: main
Are you sure you want to change the base?
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Invitation URL: |
Test Results 64 files 402 suites 0s ⏱️ Results for commit a88a3ee. ♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against a88a3ee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to issue a mediaPlayback.supportedPlaybackCommands
event from the device_init
handler to make sure existing devices get this update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this change will break any rules that users have setup to trigger a stop command for these devices. I dont see a problem with that assuming that functionality wasn't working already.
Check all that apply
Type of Change
Checklist
Description of Change
Remove stop action which is not supported by device.
Summary of Completed Tests