Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bar 300] Issues - device don't operate about 'stop' command #1797

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cchillerr
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Remove stop action which is not supported by device.

Summary of Completed Tests

Copy link

github-actions bot commented Dec 5, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Dec 5, 2024

Copy link

github-actions bot commented Dec 5, 2024

Test Results

   64 files    402 suites   0s ⏱️
2 001 tests 2 001 ✅ 0 💤 0 ❌
3 455 runs  3 455 ✅ 0 💤 0 ❌

Results for commit a88a3ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2024

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against a88a3ee

Copy link
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to issue a mediaPlayback.supportedPlaybackCommands event from the device_init handler to make sure existing devices get this update.

Copy link
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this change will break any rules that users have setup to trigger a stop command for these devices. I dont see a problem with that assuming that functionality wasn't working already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants