-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter switch add support for plug/button combination devices #1807
Open
nickolas-deboom
wants to merge
8
commits into
main
Choose a base branch
from
matter-switch-add-support-for-plug-button-combination-devices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Matter switch add support for plug/button combination devices #1807
nickolas-deboom
wants to merge
8
commits into
main
from
matter-switch-add-support-for-plug-button-combination-devices
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com:SmartThingsCommunity/SmartThingsEdgeDrivers into matter-switch-add-profile-for-button-plug-device
…thub.com:SmartThingsCommunity/SmartThingsEdgeDrivers into matter-switch-add-profile-for-button-plug-device
Duplicate profile check: Passed - no duplicate profiles detected. |
Invitation URL: |
Test Results 64 files 402 suites 0s ⏱️ Results for commit 5e12292. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5e12292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
The changes in this PR were originally in PR 1799, which was split into this PR and PR 1806. PR 1806 adds a new profile for a plug/button device, and this PR adds support in the driver for this device type (along with devices containing a plug + 2-8 button endpoints).
Summary of Completed Tests