fix-an-issue-of-thermostat-does-not-support-fan-speed #1813
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 64 files 402 suites 0s ⏱️ Results for commit 8cb7552. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8cb7552 |
lelandblue
requested review from
hcarter-775,
ctowns,
z-michel and
nickolas-deboom
| @@ -503,7 +507,7 @@ local function do_configure(driver, device) | |||
| end | |||
| profile_name = profile_name .. create_air_quality_sensor_profile(device) | |||
|
|
|||
| elseif #thermostat_eps > 0 then | |||
| elseif #thermostat_eps > 0 or device_type == TMST_DEVICE_TYPE_ID then | |||
There was a problem hiding this comment.
the get_device_type logic currently defaults to thermostat when no other device type (i.e. fan, air purifier, room ac) are found. Including this logic could jeopardize that flow.
There was a problem hiding this comment.
It is found that the get_device_type function does not handle situation where a device supports both Thermostat and Fan device type. Instead, it defaults to returning the Fan device type and proceeds to the "device_type == FAN_DEVICE_TYPE_ID" logic, which the logic do not check if the device support thermostat capability.
BTW, there is no such a profile support both fan speed and thermostat in thermostat driver folder. Are we currently not supporting a device that combines a fan and a thermostat?
There was a problem hiding this comment.
This PR is from ticket #1813
There was a problem hiding this comment.
I updated my pull request by incorporating thermostat check logic into the "device_type == FAN_DEVICE_TYPE_ID" condition to handle situations where a device supports both fan and thermostat types. Please help to revise, Many thanks~
pInksenberg
force-pushed
the
fix-an-issue-of-thermostat-does-not-support-fan-speed
branch
2 times, most recently
from
71929e6 to
18ff916
Compare
pInksenberg
force-pushed
the
fix-an-issue-of-thermostat-does-not-support-fan-speed
branch
from
18ff916 to
8cb7552
Compare
Check all that apply
Type of Change
Checklist
Description of Change
Problem:
The LengCeoi HAVC Remote were recently tested in ST App, which include Thermostat and Fan device type. However the capabilities in plugin shows incorrectly
Expectation Result:
The capabilities of thermostat, humidity, fan speed, thermostat mode, thermostat fan mode and set temperature show in the ST plugin.
Current Issue:
The plugin show fan mode and fan speed.
Analysis:
Is it found that the edge driver(matter-thermostat) will re-assign a new profile while driver initialize, and go to the Fan logic, the fan logic does not check if the device support thermostat, or humidity, which means it will re-assign the “fan-generic” for driver.
The profile name re-assign logic is changed to check if the fan speed is supported.
Related tickets: https://smartthings.atlassian.net/browse/MTR-866
Summary of Completed Tests