Hue: Remove incorrect dimming lower bound logic. #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 64 files 402 suites 0s ⏱️ Results for commit 18ae4c5. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 18ae4c5 |
kdbang
approved these changes
Dec 19, 2024
dljsjr
changed the title
FreeMasen
approved these changes
Dec 19, 2024
cjswedes
approved these changes
Dec 19, 2024
NoahCornell
approved these changes
Dec 19, 2024
This was some of the first code I wrote for the Hue driver, and I had a misunderstanding of the `min_dimming` property returned by the API. The `min_dimming` value in the API is informative, and represents a percent of the total lumens the device is capable of outputting that you will get if you request the lowest possible brightness for the bulb (1%). We were interpreting it as a lower bound on the values to send, which is not correct. This PR removes the lower bound checks, and instead clamps all dimming commands to the range of [1,100] inclusive.
dljsjr
force-pushed
the
fix/improper-philips-hue-dimming-range
branch
from
598ee95 to
18ae4c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
This was some of the first code I wrote for the Hue driver, and I had a misunderstanding of the
min_dimmingproperty returned by the API.The
min_dimmingvalue in the API is informative, and represents a percent of the total lumens the device is capable of outputting that you will get if you request the lowest possible brightness for the bulb (1%).We were interpreting it as a lower bound on the values to send, which is not correct.
This PR removes the lower bound checks, and instead clamps all dimming commands to the range of [1,100] inclusive.
Summary of Completed Tests
Tested against all bulb profiles that we support.