[Aqara] Humidity_temp_sensor Battery capability change #1853
Conversation
|
|
| end | ||
| device:emit_event(capabilities.batteryLevel.battery(batteryLevel)) | ||
| end | ||
|
|
||
| local function device_init(driver, device) | ||
| battery_defaults.build_linear_voltage_init(2.6, 3.0)(driver, device) |
|
|
|
Hi @lelandblue , I couldn't find driver sharing link for this PR. could you check? |
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
| @@ -53,27 +53,49 @@ local is_aqara_products = function(opts, driver, device) | |||
| return false | |||
| end | |||
|
|
|||
| local function device_init(driver, device) | |||
| battery_defaults.build_linear_voltage_init(2.6, 3.0)(driver, device) | |||
There was a problem hiding this comment.
battery_defaults is now unused
There was a problem hiding this comment.
This is unused and replaced with battery_level_handler
There was a problem hiding this comment.
Right. But the require needs to be removed. That's why luacheck failed.
There was a problem hiding this comment.
oh. I get it. @hjl-aqara , Could you remove line number 1?
- local battery_defaults = require "st.zigbee.defaults.battery_defaults"
Test Results 64 files 404 suites 0s ⏱️ Results for commit 7775fb9. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7775fb9 |
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests