Matter Thermostat: Use fanMode capability #2205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 68 files 444 suites 0s ⏱️ Results for commit ee21e73. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ee21e73 |
|
Invitation URL: |
nickolas-deboom
force-pushed
the
matter-thermostat-use-fan-mode-capability
branch
from
fd88017 to
10c58ef
Compare
hcarter-775
reviewed
Jun 18, 2025
hcarter-775
reviewed
Jun 20, 2025
hcarter-775
reviewed
Jun 20, 2025
nickolas-deboom
force-pushed
the
matter-thermostat-use-fan-mode-capability
branch
3 times, most recently
from
e7399c0 to
b184f83
Compare
|
Hi @nickolas-deboom. |
This change replaces the use of thermostatFanMode with fanMode, to better align with the fan modes and sequences defined by the Fan Control cluster. Also, fanMode is now used in fan profiles over airConditionerFanMode.
nickolas-deboom
force-pushed
the
matter-thermostat-use-fan-mode-capability
branch
from
c1d0935 to
ee21e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
This change replaces the use of
thermostatFanModewithfanMode, to better align with the fan modes and sequences defined by the Fan Control cluster. Note that existing static profiles will continue to utilizethermostatFanMode, so this change will only affect newly onboarded devices that use thethermostat-modularprofile.Summary of Completed Tests
Unit tests updated. Needs device testing to ensure no regression.