Skip to content

Add a generic fingerprint for Zigbee humidity sensors that include battery capability #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a generic fingerprint for Zigbee humidity sensors that include battery capability #2252

wants to merge 1 commit into from
+196 −1

Conversation

pInksenberg
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

add battery capability for generic temp/humidity sensor

Summary of Completed Tests

@github-actions GitHub Actions
Copy link

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/KPMeEWdeVPMQ

@pInksenberg pInksenberg force-pushed the support-battery-capability-for-generic-temperature-humidity-sensor branch from b0f6115 to 71c855e Compare July 14, 2025 09:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2025 •
edited
Loading

File Coverage
All files 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/plant-link/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/aqara/init.lua 93% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against c90a7c1

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2025 •
edited
Loading

Test Results

   68 files    446 suites   0s ⏱️
2 324 tests 2 324 ✅ 0 💤 0 ❌
3 920 runs  3 920 ✅ 0 💤 0 ❌

Results for commit c90a7c1.

♻️ This comment has been updated with latest results.

@pInksenberg pInksenberg force-pushed the support-battery-capability-for-generic-temperature-humidity-sensor branch 2 times, most recently from a882493 to 949ea45 Compare July 14, 2025 10:18
@pInksenberg pInksenberg changed the title support battery capability for temp/humidity sensor Add a generic fingerprint for Zigbee humidity sensors that include battery capability Jul 14, 2025
@inasail
Copy link
Contributor

inasail commented Jul 15, 2025

@greens , Would you please review this PR?
This PR is for the 2nd item to solve the frequent offline issue.
https://smartthings.atlassian.net/wiki/spaces/~546847851/pages/4013688337/Offline+Zigbee+device+analysis+-+25+06+01

greens
greens reviewed Jul 15, 2025
View reviewed changes
drivers/SmartThings/zigbee-humidity-sensor/src/test/test_humidity_temperature_battery.lua Outdated
@@ -0,0 +1,185 @@
-- Copyright 2022 SmartThings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date

updated

@pInksenberg pInksenberg force-pushed the support-battery-capability-for-generic-temperature-humidity-sensor branch from 949ea45 to c90a7c1 Compare July 16, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greens greens greens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pInksenberg @inasail @greens