-
Notifications
You must be signed in to change notification settings - Fork 499
Add default enum value to supportedAlarmvalues #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hunsup Jung <[email protected]>
Invitation URL: |
Test Results 68 files ± 0 445 suites - 3 0s ⏱️ ±0s Results for commit 44055e6. ± Comparison against base commit d69565d. This pull request removes 18 tests.
♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 44055e6 |
@@ -204,6 +204,8 @@ local function info_changed(driver, device, event, args) | |||
end | |||
end | |||
device:subscribe() | |||
device:emit_event(capabilities.lockAlarm.alarm.clear({state_change = true})) | |||
device:emit_event(capabilities.lockAlarm.supportedAlarmValues({"unableToLockTheDoor"})) -- lockJammed is madatory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about to add {visibility = {displayed = false}}
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, I missed that option. I will add it.
Signed-off-by: Hunsup Jung <[email protected]>
Type of Change
Checklist
Description of Change
DoorLockAlarm event is manadatory event in Matter spec and LockJammed is mandatory enum value.
So this patch add unableToLockTheDoor value that is mapped to LockJammed of Matter spec to supportedAlarmValues.
supportedAlarmValues is used in Routine. If supportedAlarmValues is nil, user can select all of lockAlarm Enum value. Even if device does not support some enum values, user can select those values. So we decide to add default value(unableToLockTheDoor) to supportedAlarmVlaues.
Summary of Completed Tests