WWSTCERT-8138: Add support for frient Zigbee Range Extender #2430
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 71 files 453 suites 0s ⏱️ Results for commit 099748e. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 099748e |
| end | ||
|
|
||
| local function do_refresh(driver, device) | ||
| device:send(Basic.attributes.ZCLVersion:read(device)) |
There was a problem hiding this comment.
this isn't being handled, so why does it need to be refreshed?
greens
changed the title
| device:send(PowerConfiguration.attributes.BatteryVoltage:read(device)) | ||
| device:send(IASZone.attributes.ZoneStatus:read(device)) |
There was a problem hiding this comment.
Seems like the base driver's device:refresh should be enough here. I don't think you need to define a custom handler. A unit test would confirm.
There was a problem hiding this comment.
I tried to delete a custom refresh handler, but then it is only ZCLVersion attribute from Basic cluster that is being refreshed. Unit tests for refreshing fail when there is any attribute other than ZCLVersion.
There was a problem hiding this comment.
Ah, I see. This is because for this driver, the IAS Zone attribute has not been configured. So the driver would also not be set up to receive reports from this attribute as-is, either.
In the base driver, you'll need to add this line in roughly the same place.
There was a problem hiding this comment.
After that is in place, your test results will be different.
2 participants
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests