Support robotCleanerOperatingState Routine #2443
Conversation
Signed-off-by: Hunsup Jung <[email protected]>
Signed-off-by: Hunsup Jung <[email protected]>
|
Invitation URL: |
Test Results 71 files 455 suites 0s ⏱️ Results for commit 9ce965f. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9ce965f |
Signed-off-by: Hunsup Jung <[email protected]>
HunsupJung
force-pushed
the
feature/update-rvc-routine
branch
from
388bea7 to
9ce965f
Compare
| @@ -0,0 +1,108 @@ | |||
| name: Robot Cleaner Operating State | |||
There was a problem hiding this comment.
Hey @HunsupJung why do we need this capability to be embedded? It appears the same capability def is already deployed in production
| local supportedOperatingState = {} | ||
| for _, state in ipairs(ib.data.elements) do | ||
| if OPERATING_STATE_MAP[state.elements.operational_state_id.value] ~= nil then | ||
| table.insert(supportedOperatingState, OPERATING_STATE_MAP[state.elements.operational_state_id.value].NAME) |
There was a problem hiding this comment.
does this require an augment type() call for lower lua lib integration?
| for _, attr in ipairs(ib.data.elements) do | ||
| table.insert(supportedOperatingStateCommands, OP_COMMAND_MAP[attr.value].NAME) | ||
| end | ||
| device:set_field(OPERATING_STATE_SUPPORTED_COMMANDS, supportedOperatingStateCommands, { persist = true }) |
There was a problem hiding this comment.
do we still need this table given the introduction of supportedCommands? It seems to me like the one use of it can be replaced with the capability get_latest_state api?
2 participants
Type of Change
Checklist
Description of Change
This PR is for supporting Routine of
robotCleanerOperatingStateCapability and includes follows.rvc_operational_state_list_attr_handlerhas been added to support Condition of Routine.handle_rvc_operational_state_accepted_command_listhas been updated to updatesupportedCommandsdriverSwitchedhas been added to executehandle_rvc_operational_state_accepted_command_listafter updating driver.Summary of Completed Tests