Add processing logic of motion sensor in button devices #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 456 suites 0s ⏱️ Results for commit 3601470. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3601470 |
12 tasks
|
@nickolas-deboom @hcarter-775 We closed the previous PR (#2422) and moved here. Please check the modification, thank you! |
mocelet
reviewed
Oct 13, 2025
hcarter-775
approved these changes
Oct 16, 2025
nickolas-deboom
approved these changes
Oct 16, 2025
hcarter-775
reviewed
Oct 17, 2025
| end | ||
| local motion_eps = device:get_endpoints(clusters.OccupancySensing.ID) | ||
| if #motion_eps > 0 then | ||
| profile_name = profile_name .. "-motion" |
There was a problem hiding this comment.
this may misprofile button devices that have this format but are not configured with 3 or 6 buttons. Please add a check here of something like if #motion_eps > 0 and (num_button_eps == 3 or num_button_eps == 6) then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
The modification originated from this PR (#2422). Considering that there was a big code refactoring, we closed the previous submission and proposed this new PR.
In the past, the button devices with motion sensor did not support their complete functions. Now add relevant processing logic, so that this kind of devices can display the sensor normally in the plugin.
Summary of Completed Tests
The unit test file is contained in the commit, and all tests can pass. In addition, we have tested it on device and the function was normal.