Add driver support for Matter cameras #2503

nickolas-deboom · 2025-10-28T21:11:03Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2025-10-28T21:11:32Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-10-28T21:12:17Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/WnlLLG6zG1lK

github-actions · 2025-10-28T21:15:09Z

Test Results

71 files 465 suites 0s ⏱️
2 411 tests 2 298 ✅ 0 💤 0 ❌ 113 🔥
4 094 runs 3 910 ✅ 0 💤 0 ❌ 184 🔥

For more details on these errors, see this check.

Results for commit 5662469.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-28T21:15:11Z

File	Coverage
All files	`28%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/utils/switch_utils.lua	`23%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/utils/color_utils.lua	`9%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/utils/device_configuration.lua	`16%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/utils/switch_fields.lua	`99%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/utils/embedded_cluster_utils.lua	`32%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/generic_handlers/attribute_handlers.lua	`13%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/generic_handlers/event_handlers.lua	`24%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/generic_handlers/capability_handlers.lua	`21%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua	`80%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/aqara_cube/init.lua	`28%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua	`3%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 5662469

hcarter-775

Just an initial review but I figured I'd get these thoughts out there

drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua

hcarter-775 · 2025-10-29T14:43:59Z

drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua

+        if child_profile then
+          num_floodlight_eps = num_floodlight_eps + 1
+          local name = string.format("%s %d", "Floodlight", num_floodlight_eps)
+          driver:try_create_device(


I don't think we should be trying to create new children every init

It's gated by CAMERA_INITIALIZED

why do we have this in init at all is my question then? Why not have it in do_configure if it's meant to be a one-time call

We could definitely move it to configure. It was placed here during testing because it was easier to just delete the inventory db to clear CAMERA_INITIALIZED and get a new profile update rather than having to re-onboard.

hcarter-775 · 2025-10-29T14:47:11Z

drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua

+
+local function info_changed(driver, device, event, args)
+  -- resubscribe and initialize relevant camera capabilities if a modular update has occurred
+  if not compare_components(device.profile.components, args.old_st_store.profile.components) then


not compare_components is kinda odd wording... maybe are_profiles_equal or something like that? And then we could just pass in device.profile if we wanted to be clearer with the now.

Also, this is a useful function, I might suggest moving it to switch_utils.

hcarter-775 · 2025-10-29T14:48:24Z

drivers/SmartThings/matter-switch/src/init.lua

  supported_capabilities = fields.supported_capabilities,
  sub_drivers = {
    require("sub_drivers.aqara_cube"),
+    require("sub_drivers.camera"),


this is a large bit of code... would we be able to leverage @cjswedes's improvements to subdriver loading to avoid loading it?

drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua

hcarter-775 · 2025-10-29T15:09:57Z

drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua

+end
+
+local function status_light_enabled_attr_handler(driver, device, ib, response)
+  local component = device.profile.components[component_map.statusLed]


to add to this comment, I think it could be good to get a clearer mapping between endpoints and these components so that we can endpoint_to_component in the emit_event_for_endpoint function. This may help cut out edge cases and bugs by putting all this mapping logic together into one place.

I agree, I will add proper component mapping and switch away from using emit_component_event

Thinking about this more, there isn't any assurance that the clusters will be implemented on separate endpoints, so I'm not sure what the best way to handle this would be. Since this subdriver only applies to one profile, we know which capabilities belong in each component and so therefore always know where to route them with emit_component_event. So there might not be much benefit in further endpoint/component mapping. What do you think?

drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua

* Use assign_child_profile from device_configuration * Use find_child from switch_utils * Move st.utils to a global require

To avoid breaking routines, add in any capabilities from the current profile before updating the profile with the new list of component capabilities.

Compare the newly generated component capabilities list against the current device profile rather than saving this information in a persisted field.

nickolas-deboom · 2025-11-04T20:48:13Z

drivers/SmartThings/matter-switch/src/init.lua

  },
  supported_capabilities = fields.supported_capabilities,
  sub_drivers = {
    require("sub_drivers.aqara_cube"),


lazy loading for other subdrivers is implemented in #2525

nickolas-deboom requested review from ctowns, hcarter-775, samadDotDev and z-michel October 28, 2025 21:11

hcarter-775 reviewed Oct 29, 2025

View reviewed changes

nickolas-deboom and others added 9 commits November 4, 2025 14:16

Add driver support for Matter cameras

57d3a90

Addressing review feedback

fd7302d

fixup

6bbf7c2

* Use assign_child_profile from device_configuration * Use find_child from switch_utils * Move st.utils to a global require

Move subscribe out of add_camera_subscribed_attributes function

20e2f2f

Fix default view port setting

04e881e

Fix issue with videoStreams watermark and osd attributes

84c4d8f

fix y coordinates in setDefaultViewport handler

22ed6f3

Ensure that capabilities are not removed from the camera profile

2c5cb29

To avoid breaking routines, add in any capabilities from the current profile before updating the profile with the new list of component capabilities.

Remove OPTIONAL_SUPPORTED_COMPONENT_CAPABILITIES field

6dec746

Compare the newly generated component capabilities list against the current device profile rather than saving this information in a persisted field.

nickolas-deboom force-pushed the add-matter-camera-support branch 2 times, most recently from 66f0b0a to 31c2294 Compare November 4, 2025 20:47

nickolas-deboom commented Nov 4, 2025

View reviewed changes

Lazy load camera subdriver

5662469

nickolas-deboom force-pushed the add-matter-camera-support branch from 31c2294 to 5662469 Compare November 4, 2025 20:54

Add driver support for Matter cameras #2503

Are you sure you want to change the base?

Add driver support for Matter cameras #2503

Uh oh!

Conversation

nickolas-deboom commented Oct 28, 2025

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hcarter-775 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickolas-deboom Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 28, 2025 •

edited

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading

nickolas-deboom Oct 29, 2025 •

edited

Loading