Matter Smoke Alarm: add smoke-temp-humidity-battery profile #2513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 71 files 459 suites 0s ⏱️ Results for commit 2287875. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2287875 |
| @@ -0,0 +1,27 @@ | |||
| name: smoke-temp-humidity-battery | |||
There was a problem hiding this comment.
Do we want a corresponding batteryLevel profile?
There was a problem hiding this comment.
what I'd prefer to do is add modular handling for this device type I think. I don't think the lift on that would be extremely high
There was a problem hiding this comment.
Yeah I agree that'd be nice
nickolas-deboom
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add a new smoke profile.
Summary of Completed Tests