add rgbw,dimming light and water sensor #724
Conversation
|
|
|
Channel deleted. |
|
zigbee-switch_coverage.xml
zigbee-water-leak-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against c1f2936 |
There was a problem hiding this comment.
you have to require the new sub-driver in the base driver or the code will not be loaded: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-water-leak-sensor/src/init.lua#L55
|
Add Sengled water leak sensor E1L-G7K
|
|
Loop 徐总
zhuge
From: github-actions[bot]
Date: 2023-05-16 22:42
To: SmartThingsCommunity/SmartThingsEdgeDrivers
CC: sengled-gezhu; Author
Subject: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] add rgbw,dimming light and water sensor (PR #724)
Invitation URL:
https://bestow-regional.api.smartthings.com/invite/akMX6a5znXlb
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Loop 徐总
zhuge
From: zhuge
Date: 2023-05-18 09:38
To: SmartThingsCommunity/SmartThingsEdgeDrivers; SmartThingsCommunity/SmartThingsEdgeDrivers
CC: Author
Subject: Re: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] add rgbw,dimming light and water sensor (PR #724)
Loop 徐总
zhuge
From: github-actions[bot]
Date: 2023-05-16 22:42
To: SmartThingsCommunity/SmartThingsEdgeDrivers
CC: sengled-gezhu; Author
Subject: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] add rgbw,dimming light and water sensor (PR #724)
Invitation URL:
https://bestow-regional.api.smartthings.com/invite/akMX6a5znXlb
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Hello @sengled-gezhu Can you please resolve the conflicts on this PR and also sign the CLA? Also - We need you to write tests for the additional code that your adding. Thank you for making these improvements so this can progress forward. |
|
Yes, I have modified the previous conflict content and signed the CLA.
zhuge
From: lelandblue
Date: 2023-09-08 21:41
To: SmartThingsCommunity/SmartThingsEdgeDrivers
CC: sengled-gezhu; Mention
Subject: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] add rgbw,dimming light and water sensor (PR #724)
Hello @sengled-gezhu
Can you please resolve the conflicts on this PR and also sign the CLA?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thank you. Please also provide unit tests that cover the changes that your looking to add. We require that tests be provided of the new code that is being contributed. Please this page for more information. https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver |
|
Hello @sengled-gezhu In order for this to proceed we need you to add unit test coverage for the changes that your proposing in the init file. Test coverage is in the form of adding unit tests, in a .test file in a new commit on the PR. This is similar to the discussion we have been having with PR : 716. Thank you for your communication. |
|
1.For rgbw and dimming light, We did not add a subdirectory driver, so we can simply follow the default process for authentication. |
|
Hello @lelandblue
1.For rgbw and dimming light, We did not add a subdirectory driver, so we can simply follow the default process for authentication.
2.For water leak sensor device, we have added a. text file to the test directory.
zhuge
From: lelandblue
Date: 2023-10-30 21:48
To: SmartThingsCommunity/SmartThingsEdgeDrivers
CC: sengled-gezhu; Mention
Subject: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] add rgbw,dimming light and water sensor (PR #724)
Hello @sengled-gezhu In order for this to proceed we need you to add unit test coverage for the changes that your proposing in the init file. Test coverage is in the form of adding unit tests, in a .test file in a new commit on the PR. This is similar to the discussion we have been having with PR : 716.
Thank you for your communication.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
drivers/SmartThings/zigbee-water-leak-sensor/src/sengled/init.lua
Outdated
Show resolved
Hide resolved
Co-authored-by: Steven Green <[email protected]>
Co-authored-by: Steven Green <[email protected]>
|
Hello @sengled-gezhu Please see the recent comments on this PR, thank you. |
|
Hello @lelandblue, |
|
Yes @sengled-gezhu. You need to provide a profile name in the fingerprint file for the sengled/E23-N11 device. As it is written today, this device would not work when levering your changes. I have left a review and mentioned to you in that line where the code change needs to occur. We cannot proceed with out that change. |
|
Hello @lelandblue,
|
| local PowerConfiguration = clusters.PowerConfiguration | ||
|
|
||
| local FINGERPRINTS = { | ||
| { mfr = "SENGLED", model = "E1L-G7K" } |
There was a problem hiding this comment.
| { mfr = "SENGLED", model = "E1L-G7K" } | |
| { mfr = "sengled", model = "E1L-G7K" } |
Your tests are failing here because the capitalization does not match.
I'd also like to point out that you could have avoided a subdriver entirely here by just adding the relevant info to this file: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-water-leak-sensor/src/configurations.lua
If you feel that a 5 minute maximum reporting interval for your sensor is necessary and won't negatively impact your battery life too much, though, you can continue to use this sub-driver.
|
Hello, @greens, |
|
***@***.***
For the E23-N11 product, we added "deviceProfileName: on-off-level" 2 days ago.
Please refer to line 2147 of the drivers/SmartThings/zigbee-switch/fingerprints.yml file,
as shown in the following figure:
zhuge
From: lelandblue
Date: 2023-11-10 01:16
To: SmartThingsCommunity/SmartThingsEdgeDrivers
CC: sengled-gezhu; Mention
Subject: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] add rgbw,dimming light and water sensor (PR #724)
@lelandblue commented on this pull request.
In drivers/SmartThings/zigbee-switch/fingerprints.yml:
@@ -2135,6 +2135,15 @@ zigbeeManufacturer:
model: ROB_200-011-0
deviceLabel: ROBB SMARRT Zigbee dimmer 2-wire
deviceProfileName: light-level-power-energy
+ - id: sengled/E23-N13
+ deviceLabel: Sengled Multicolor par38
+ manufacturer: sengled
+ model: E23-N13
+ deviceProfileName: rgbw-bulb
+ - id: "sengled/E23-N11"
+ deviceLabel: Sengled Light par38
+ manufacturer: sengled
+ model: E23-N11
@sengled-gezhu You need to add a line and define the profile that the device should join to here. Please review the capabilities of the E23-N11 device and match it to a profile.
I believe you would want something like:
"deviceProfileName: rgbw-bulb" or "deviceProfileName: on-off-level"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
* add rgbw,dimming light and water sensor * modify init.lua * add a .text file for sengled water leak sensor. * Update drivers/SmartThings/zigbee-water-leak-sensor/src/sengled/init.lua Co-authored-by: Steven Green <[email protected]> * Update drivers/SmartThings/zigbee-water-leak-sensor/src/init.lua Co-authored-by: Steven Green <[email protected]> * add profile name for E23-N11 * add zigbee-water leak sensor --------- Co-authored-by: lelandblue <[email protected]> Co-authored-by: Steven Green <[email protected]>
Add three Sengled zigbee devices:
Add the init.lua file to the path ~\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-water-leak-sensor\src\sengled.
Modified ~\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-water-leak-sensor\fingerprints.yml file, a new device type E1L-G7K is added.
Modified ~\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-switch\src\rgbw-bulb\init.lua file, a new device type E23-N13 is added.
Modified ~\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-switch\fingerprints.yml file, a new device type E23-N13 is added.
Modified ~\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-switch\src\zigbee-dimming-light\init.lua file, a new device type E23-N11 is added.
Modified ~\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-switch\fingerprints.yml file, a new device type E23-N11 is added.