-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yeelight Matter Request #906
Yeelight Matter Request #906
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Channel deleted. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against e9cede9 |
Pull request for Yeelight Cubes. Update light-level-colorTemperature-2700k-6500k.yml
bf1da45
to
53afb48
Compare
- id: "Yeelight Smart Lamp" | ||
deviceLabel: Yeelight Smart Lamp | ||
vendorId: 0x1312 | ||
productId: 0x1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would add a leading zero to make this 0x01
to for consistency with the other fingerprints above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -0,0 +1,26 @@ | |||
name: light-level-colorTemperature-2700k-6500k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This profile is a duplicate of the profile light-color-level-2700K-6500K
that was introduced here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/872/files
Please delete this file and then update your repo to include the latest changes, then point your fingerprint to the duplicate profile that already exists. Then this should be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the profile to be 2710 instead of 2700 per Yeelight's request.
Per Yeelights request the minimum color level needs to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Jacob!
Pull request for Yeelight Cubes.