Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yeelight Matter Request #906

Merged

Conversation

jacobvoegele
Copy link
Contributor

Pull request for Yeelight Cubes.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Channel deleted.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results

     54 files     345 suites   0s ⏱️
1 622 tests 1 622 ✔️ 0 💤 0
2 842 runs  2 842 ✔️ 0 💤 0

Results for commit e9cede9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

File Coverage
All files 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against e9cede9

Pull request for Yeelight Cubes.

Update light-level-colorTemperature-2700k-6500k.yml
- id: "Yeelight Smart Lamp"
deviceLabel: Yeelight Smart Lamp
vendorId: 0x1312
productId: 0x1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would add a leading zero to make this 0x01 to for consistency with the other fingerprints above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -0,0 +1,26 @@
name: light-level-colorTemperature-2700k-6500k
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This profile is a duplicate of the profile light-color-level-2700K-6500K that was introduced here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/872/files

Please delete this file and then update your repo to include the latest changes, then point your fingerprint to the duplicate profile that already exists. Then this should be good to go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the profile to be 2710 instead of 2700 per Yeelight's request.

Per Yeelights request the minimum color level needs to be changed.
Copy link
Contributor

@ctowns ctowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Jacob!

@lelandblue lelandblue merged commit ee9e72b into SmartThingsCommunity:main Oct 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants