-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBL driver clean commit #958
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Channel deleted. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9822df5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @varzac
Could you pull the latest code from main (https://github.com/cchillerr/SmartThingsEdgeDrivers), we have just applied a patch to improve the performance of driver. Thanks.
You can do this in your own branch, you just need to rebase to include all the latest changes from the main repo in your repo. I pulled in your changes but your code does not currently pass the linter
|
Hi @varzac |
Thank you! I have updated this PR to include the latest, and I have also run the CI on your PR so both channel invites should use the correct driver now. |
Closing as this went to prod as #842 |
This is a re-upload of #842 to test the latest CI changes.