[Aqara] Smart Wall Switch(With Neutral, No Neutral) #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3a268b3 |
greens
reviewed
Sep 18, 2023
Comment on lines
84
to
89
| elseif device.network_type == "DEVICE_EDGE_CHILD" then | ||
| device:emit_event(capabilities.button.supportedButtonValues({ "pushed" }, | ||
| { visibility = { displayed = false } })) | ||
| device:emit_event(capabilities.button.numberOfButtons({ value = 1 }, | ||
| { visibility = { displayed = false } })) | ||
| device:emit_event(capabilities.button.button.pushed({ state_change = false })) |
There was a problem hiding this comment.
just move the identical code from above outside of the if block
also write some tests to capture this behavior.
There was a problem hiding this comment.
I applied the changes you requested.
greens
approved these changes
Sep 19, 2023
greens
requested changes
Sep 19, 2023
greens
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix routine condition error on child button of light switch