Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eve Weather Pull Request #968

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Eve Weather Pull Request #968

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faa645d
Eve Weather Pull Request
jacobvoegele Sep 19, 2023
88b425f
Update fingerprints.yml
jacobvoegele Sep 19, 2023
44611ed
Merge branch 'main' into Eve-Weather
jacobvoegele Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions drivers/SmartThings/matter-sensor/fingerprints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ matterManufacturer:
vendorId: 0x130a
productId: 0x004D
deviceProfileName: contact-battery
- id: "Eve/Weather"
deviceLabel: Eve Weather
vendorId: 0x130a
productId: 0x57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you add the leading zeroes for consistency with other fingerprints in this file?

Suggested change
productId: 0x57
productId: 0x0057

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

deviceProfileName: temperature-humidity-battery

matterGeneric:
- id: "matter/contact/sensor"
Expand Down
Loading