Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG-8651 Aeotec Nano Shutter: add missing event #987

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

greens
Copy link
Contributor

@greens greens commented Sep 25, 2023

The stateless curtain power button needs to set its available command values before it will function correctly in the app. This was done in the DTH but was missed in the porting work.

I've added changes so that a refresh of the device should bring an already-installed device back to a good state. These changes can be removed at a later date as future installs will have them from the added handler changes.

The stateless curtain power button needs to set its available command values before it will function correctly in the app. This was done in the DTH but was missed in the porting work.

I've added changes so that a refresh of the device should bring an already-installed device back to a good state. These changes can be removed at a later date as future installs will have them from the added handler changes.
@greens greens requested a review from ctowns September 25, 2023 18:00
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Channel deleted.

@github-actions
Copy link

Test Results

     52 files     341 suites   0s ⏱️
1 619 tests 1 619 ✔️ 0 💤 0
2 804 runs  2 804 ✔️ 0 💤 0

Results for commit eae2020.

@github-actions
Copy link

File Coverage
All files 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/iblinds-window-treatment/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/iblinds-window-treatment/v3.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/window-treatment-venetian/qubino-flush-shutter/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/window-treatment-venetian/fibaro-roller-shutter/init.lua 84%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against eae2020

@greens greens merged commit 7824283 into main Sep 28, 2023
10 checks passed
@greens greens deleted the bugfix/BUG-8651 branch September 28, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants